mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 34835: Add constexpr to C++ whitelist
Date Wed, 05 Aug 2015 09:18:42 GMT


> On Aug. 4, 2015, 8:03 p.m., Anand Mazumdar wrote:
> > docs/mesos-c++-style-guide.md, line 557
> > <https://reviews.apache.org/r/34835/diff/4/?file=993626#file993626line557>
> >
> >     This line does not wrap over and muddles up the UI with a scroll bar. The other
examples for const expressions also seem to be broken. Can we fix these ?

Thanks for bringing this to attention! The syntax in the doc is "not wrong per se" and the
file looks fine in a gist, but yet our web site generator renders it as observed. I created
a ticket for this and I have a fix that I will put up for review shortly.

https://issues.apache.org/jira/browse/MESOS-3207


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review94172
-----------------------------------------------------------


On June 26, 2015, 3:36 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 3:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd Mathiske, Ben
Mahler, Dave Lester, Ian Downes, Joerg Schad, Joris Van Remoortere, Michael Park, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-2784
>     https://issues.apache.org/jira/browse/MESOS-2784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add constexpr to C++11 whitelist
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md a8bec8e242a57a9cb4f5fe96932eebac39ad65a1 
> 
> Diff: https://reviews.apache.org/r/34835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message