mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 36979: Updating all references to os::shell
Date Wed, 05 Aug 2015 04:16:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94177
-----------------------------------------------------------



src/slave/containerizer/isolators/network/port_mapping.cpp (line 1579)
<https://reviews.apache.org/r/36979/#comment148718>

    nit: this seems to fit on a single line.



src/tests/containerizer/isolator_tests.cpp (line 1269)
<https://reviews.apache.org/r/36979/#comment148719>

    You are right that the awk did not actually seem to accomplish anything meaningful here.



src/tests/containerizer/port_mapping_tests.cpp (lines 971 - 974)
<https://reviews.apache.org/r/36979/#comment148720>

    Another illustration of why a tuple return type might be a better option for os::shell()
:-)
    
    But regardless, I'd change this code to something more suggestive (it's a test case after
all), or at least would add a comment that clarifies the intention.



src/tests/containerizer/port_mapping_tests.cpp (line 986)
<https://reviews.apache.org/r/36979/#comment148721>

    ditto. 
    + extra newline.


- Artem Harutyunyan


On Aug. 4, 2015, 5:55 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36979/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 5:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-3142
>     https://issues.apache.org/jira/browse/MESOS-3142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updating all references to os::shell
> For more details see MESOS-3142.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp a070c3200f0a0ac48ec86451749c7faf10c7f6a7 
>   src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 3f6e9df8711995d0dd3903c6170fdd5ad61aac5a

>   src/tests/containerizer/isolator_tests.cpp ff6e2b7e190a58a4809d6e71addb15dabe418e17

>   src/tests/containerizer/port_mapping_tests.cpp 4bee74acba2b1472c80cabbc9d0384bd04c543aa

> 
> Diff: https://reviews.apache.org/r/36979/diff/
> 
> 
> Testing
> -------
> 
> make check
> *Note*: this patch fixes breakages introduce by the refactoring in: https://reviews.apache.org/r/36978
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message