mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks
Date Tue, 04 Aug 2015 16:33:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 4, 2015, 4:33 p.m.)

Review request for mesos, Ben Mahler and Vinod Kone.


Added functionality to failover http frameworks.

Bugs: MESOS-2294

Repository: mesos

Description (updated)

Split review out of r36318. This change adds the functionality of making a http call for subscribe
and the master responding with a subscribed event on the persistent stream.

Also added functionality for framework failover equivalent of re-register. It should now be
possible to merge the subscribed(...) introduced in this review and the re-factor that happened
in MESOS-3182.

- Made a new function for exited()/failoverFramework for http frameworks that invoke into
the common continuation function for pid/http frameworks thereafter.
- The re-register functionality equivalent goes in _subscribe(...)

Diffs (updated)

  src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f 
  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 


Testing (updated)

make check + adding tests in a different patch.


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message