mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.
Date Tue, 04 Aug 2015 06:36:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
-----------------------------------------------------------


Thanks for this Artem! I applied the patch and it works. Just a minor nit and a question.


src/tests/containerizer/memory_test_helper.cpp (line 75)
<https://reviews.apache.org/r/37065/#comment148500>

    `s/a/the/`



src/tests/containerizer/memory_test_helper.cpp (line 81)
<https://reviews.apache.org/r/37065/#comment148501>

    What's the significance in the order in which these are called? I would've expected something
like:
    
    ```
      // Make sure that all pages that are going to be mapped into the
      // address space of this process become unevictable. This is needed
      // for testing cgroup oom killer.
    #ifdef __APPLE__
      if (mlock(rss, size.bytes()) != 0)
    #else
      if (mlockall(MCL_FUTURE) != 0)
    #endif
      {
        return ErrnoError("Failed to make pages to be mapped unevictable");
      }
    ```


- Michael Park


On Aug. 4, 2015, 6:32 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 6:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
>     https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_test_helper.cpp 5e40b747f4266e7532baf8fd02ea5db0955124d2

> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message