mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 36847: Added HTTP Delete Method.
Date Mon, 03 Aug 2015 17:51:11 GMT


> On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 736
> > <https://reviews.apache.org/r/36847/diff/4/?file=1023560#file1023560line736>
> >
> >     please don't use abbreviations.
> >     `delete()` is the HTTP method name.
> >     
> >     I'm almost sure it violates our style guide (and I'm positive it violates Google's).

Using delete() unfortunately violates c++ list of reserved keyword.... Previously tried something
like sendDeleteRequest which people found to long/verbose and inconsistent...


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93923
-----------------------------------------------------------


On July 29, 2015, 1:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 1:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3152
>     https://issues.apache.org/jira/browse/MESOS-3152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9

>   3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f 
>   3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445

> 
> Diff: https://reviews.apache.org/r/36847/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message