mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON
Date Sun, 31 May 2015 02:58:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 31, 2015, 2:58 a.m.)

Review request for mesos, haosdent huang and Niklas Nielsen.


Fixed an issue with tests

Bugs: MESOS-2340

Repository: mesos


Jira: MESOS-2340

This is a preliminary step to enabling JSON API
for Master Discovery via Zookeeper.

We currently save the MasterInfo PB to ZK
serializing directly the binary data, so that
for clients to retrieve that information, they
need to either link up with libmesos or
obtain the PB definition (in mesos/mesos.proto).

This change only provides the (de)serialization
utility methods and associated tests.

Diffs (updated)

  src/ e7281ac6667562a27b0427b0ba7f41de98702928 
  src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 
  src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
  src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
  src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7 
  src/tests/common/parse_tests.cpp PRE-CREATION 



make check


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message