mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Wang" <markgic...@gmail.com>
Subject Re: Review Request 34529: Add non-const reference version of Option<T>::get.
Date Sun, 31 May 2015 01:12:08 GMT


> On May 29, 2015, 8:21 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 115
> > <https://reviews.apache.org/r/34529/diff/2/?file=972517#file972517line115>
> >
> >     Could you please elaborate why we are adding this?
> >     I can't tell the difference between this and the function above.
> >     IMO if we want to change the name then we should refactor the original function
as opposed to having 2 copies.
> >     If we did have 2 versions of the same function, would it make more sense to
delegate one of them to the other (as we did with the other operators added in this patch)?
> >     
> >     I think this patch can get committed if we take this out. Do you want to pull
this extra function (and tests) into a seperate patch to move the discussion and let the original
JIRA get resolved? :-)

Same question as I had here :P
https://issues.apache.org/jira/browse/MESOS-2716?focusedCommentId=14560479&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14560479
So I'll pull this out, and take your first suggestion to change the name and refactor the
original get() in another patch. (btw, How do I create a new JIRA to track this?)


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85792
-----------------------------------------------------------


On May 27, 2015, 6:40 a.m., Mark Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34529/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 6:40 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2716
>     https://issues.apache.org/jira/browse/MESOS-2716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add non-const reference version of Option<T>::get.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp ea79b501d9ed7b7da9636ce9c9c590738a586993

>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c

> 
> Diff: https://reviews.apache.org/r/34529/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Mark Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message