mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <>
Subject Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.
Date Sat, 30 May 2015 21:00:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 30, 2015, 9 p.m.)

Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.

Bugs: MESOS-2781

Repository: mesos


Fix routing ingress/fq_codel search returning wrong qdisc.

Add new checking to verify that operations occur on the correct interface and change the behaviour
of create() operation to return false rather than an error if creation fails if the interface
does not exist (now consistent with exists() and remove()).

Diffs (updated)

  src/linux/routing/queueing/fq_codel.hpp 7de1e31d4c43ac9cbffab1e472ea51140719f900 
  src/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc 
  src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed 
  src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 
  src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 



make check


Paul Brett

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message