mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 34258: Removed os::dirname and os::basename.
Date Sun, 17 May 2015 19:50:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34258/
-----------------------------------------------------------

(Updated May 17, 2015, 7:50 p.m.)


Review request for mesos and Cody Maloney.


Bugs: MESOS-1303
    https://issues.apache.org/jira/browse/MESOS-1303


Repository: mesos-incubating


Description
-------

os::dirname and os::basename were not thread safe on OSX. Replacements are path::dirname and
path::basename.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp d2ca4be 

Diff: https://reviews.apache.org/r/34258/diff/


Testing
-------

make check on trailing RR.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message