mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <>
Subject Re: Review Request 34256: Added Path::dirname() and Path::basename().
Date Sun, 17 May 2015 19:46:14 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2015, 7:46 p.m.)

Review request for mesos and Cody Maloney.


Moved implementations into Path.

Summary (updated)

Added Path::dirname() and Path::basename().

Bugs: MESOS-1303

Repository: mesos-incubating

Description (updated)

Introducing Path::dirname() and Path::basename() as a thread safe replacement of the respective
system functions. Also contains new tests covering corner cases.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp d4df650 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp cf35412 


Testing (updated)

make check (including new tests).

Result comparison to match ::dirname and ::basename on interesting cases.


Till Toenshoff

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message