mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <>
Subject Re: Review Request 32108: Added manual make for readability training source code
Date Tue, 28 Apr 2015 01:44:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 27, 2015, 6:44 p.m.)

Review request for mesos, Benjamin Hindman and Ben Mahler.


Made the pre-commit hook syntax-check the redability source code.

Repository: mesos


Readability source code now has a Makefile that is generated by bootstrap and configure. "cd
build/readability; make" compiles the sources in "readability/". No linking occurs. This is
just to ensure that we have syntactially correct and type-checked example files.

Slightly rearranged the content of naming_*.cpp and broke out an extra file for whitespace


Diffs (updated)
----- 589ae97d0432370b462576cd1985544564893999 
  readability/ PRE-CREATION 
  readability/ PRE-CREATION 
  readability/naming_comments.cpp PRE-CREATION 
  readability/naming_review.cpp PRE-CREATION 
  readability/whitespace_comments.cpp PRE-CREATION 
  readability/whitespace_review.cpp PRE-CREATION 
  support/hooks/pre-commit 09ce57816b4aa953fea6bd9574223626edb23699 


Testing (updated)

cd build/readability; make

Also observed that the pre-commit hook does this as well.


Bernd Mathiske

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message