lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [lucenenet] NightOwl888 opened a new pull request #504: Highlighter Updates
Date Sat, 24 Jul 2021 18:51:10 GMT

NightOwl888 opened a new pull request #504:

   - Implemented `IFormattable` and made culture-aware overloads of `ToString()` on `WeightedPhraseInfo`
and `WeightedFragInfo`
   - **BREAKING:** `Lucene.Net.Highlighter.VectorHiglight.ScoreOrderFragmentsBuilder.ScoreComparer`:
Implemented singleton pattern so the class can only be used via the `Default` property.
   - **PERFORMANCE**: Used `J2N.Collections.Generic.Extensions.ListExtensions.RemoveAll()`
extension method to optimize forward deletion while iterating without moving any underlying
items more than once. This eliminates 2 collections that were used to track the items to delete
until the enumerator was complete, which not only allocated extra memory but used a slower
method to remove the items from the list.
   This PR includes the changes from and supersedes #498. Its tests failed because the `IFormattable`
fix is required to pass the invariant culture for the tests.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail:

For queries about this service, please contact Infrastructure at:

View raw message