lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on pull request #310: WIP Benchmarks between nuget versions
Date Wed, 21 Apr 2021 08:48:45 GMT

NightOwl888 commented on pull request #310:
URL: https://github.com/apache/lucenenet/pull/310#issuecomment-823894606


   I have rebased against the master branch so this is up to date again.
   
   I also rearranged the project so all of the NuGet versions are defined in `BuildConfigurations.cs`.
I also got it working (sort of) with a [local build](https://github.com/dotnet/BenchmarkDotNet/issues/1486)
from source so it can be compared against the NuGet packages. Unfortunately, I couldn't find
any documentation of what the defaults are for the properties of a `Release` build, so this
appears to be basically building a `Debug` build with optimizations turned on. Requires more
research to set all of the `Release` properties when the configuration is `LocalBuild`.
   
   This isn't quite up to the state which we can merge it, though - we still need a top-level
`benchmarks` folder as mentioned in #349 and to reorganize the project as well as rename this
from `Lucene.Net.Tests.BenchmarkDotNet` to something that doesn't include the word `Tests`,
but it is a few steps closer to where we need to be and it is quicker to update all of the
benchmarks with a new set of NuGet packages now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message