lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 opened a new pull request #443: Fixes Lucene.Net.Benchmark.ByTask.Feeds.SpatialDocMaker.DictionaryAnonymousClass implementation
Date Mon, 15 Mar 2021 08:46:42 GMT

NightOwl888 opened a new pull request #443:
URL: https://github.com/apache/lucenenet/pull/443


   Since Dictionary `this[key]` is not marked virtual in .NET, subclassing `Dictionary<string,
string>` is not a valid approach. So we implement `IDictionary<string, string>` instead.
   
   Also made note of other TODOs about missing parameters in Spatial4n: https://github.com/NightOwl888/Spatial4n/issues/1.
Since we don't want to introduce breaking changes in Spatial4n, there is no need to do anything
in Lucene.NET when it is fixed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message