lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yogi Valani <dr.val...@gmail.com>
Subject Re: [GitHub] [lucenenet] NightOwl888 opened a new pull request #442: Reviewed Reverse() calls
Date Sun, 14 Mar 2021 12:54:34 GMT
Hi,

I have repeatedly asked to be removed from this mailing list. This mailing
list is in violation of UK Marketing and Advertising laws (
https://www.gov.uk/marketing-advertising-law/direct-marketing)

But can someone please remove my mail address from the
dev@lucenenet.apache.org list; and update all future mails sent to have an
unsubscribe link in the emails sent.

Regards

Yogi

NB:  I do understand this is an open source project and benefits to the IT
community as a whole. By referring to the law, this is in no way is this a
threat (direct or implied) of legal action.

On Sun, 14 Mar 2021 at 12:40, GitBox <git@apache.org> wrote:

>
> NightOwl888 opened a new pull request #442:
> URL: https://github.com/apache/lucenenet/pull/442
>
>
>    Since `Reverse()` on collections is an expensive operation, this review
> is just to ensure we aren't using it unnecessarily.
>
>    There was one instances in `Lucene.Net.Suggest` where using `Stack<T>`
> could be used instead of reversing the output, and one instance where
> sorting the output was completely unnecessary. In the latter case, using
> `JCG.HashSet<T>` has already solved the test failures because its
> `Equals()` method respects set equality by default.
>
>    Also, an unnecessary lock was removed that had been added during the
> port.
>
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message