lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] rclabo commented on a change in pull request #438: Don't insert extra newline in TFIDFSim's score explanation
Date Fri, 12 Mar 2021 23:48:18 GMT

rclabo commented on a change in pull request #438:
URL: https://github.com/apache/lucenenet/pull/438#discussion_r593510872



##########
File path: src/Lucene.Net/Search/Similarities/TFIDFSimilarity.cs
##########
@@ -751,7 +751,7 @@ public override void Normalize(float queryNorm, float topLevelBoost)
         private Explanation ExplainScore(int doc, Explanation freq, IDFStats stats, NumericDocValues
norms)
         {
             Explanation result = new Explanation();
-            result.Description = "score(doc=" + doc + ",freq=" + freq + "), product of:";
+            result.Description = "score(doc=" + doc + ",freq=" + freq.Value + "), product
of:";

Review comment:
       Instead of 5.x it'd be good if the comment said 5.0 since that was the specific version
where this change was introduced and it was a bit hard to track down given that area of the
code was substantially refactored in 5.2.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message