lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] rauhs commented on pull request #438: Don't insert extra newline in TFIDFSim's score explanation
Date Thu, 11 Mar 2021 16:48:33 GMT

rauhs commented on pull request #438:
URL: https://github.com/apache/lucenenet/pull/438#issuecomment-796879882


   First: Thanks for the quick feedback!
   
   There is no real bug. I have just noticed the annoying newline in my explanations for a
few months of working with 4.8 lucene and today was the day that it has bothered me too much
so I went into the git repos and realized it was fixed in the Java version. (See my link).
   
   So no, there is no real reason other than getting rid of this annoying newline everywhere
which makes reading the explanation a bit easier.
   
   > But this appears to be part of a larger design change to TFIDFSimilarity that occurred
in Lucene 5.x, rather than an actual bug that needs to be fixed.
   
   I don't think this change was part of that rework. Here it was just about the newline.
   
   I'm fine with a rejection here, no big deal to me. I can live with the newline. Whatever
you prefer. Cheers


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message