lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 opened a new pull request #387: Fixes several code quality issues (Code Analysis)
Date Tue, 10 Nov 2020 15:30:26 GMT

NightOwl888 opened a new pull request #387:
URL: https://github.com/apache/lucenenet/pull/387


   This PR:
   
   1. Adds an `.editorconfig` file to take control over the code analysis rules.
   2. Fixes most of the code analysis suggestions that were given.
   3. Disables some code analysis rules (such as nesting classes, catching common exceptions,
and those that only apply to .NET Standard 2.1+).
   4. Disables additional code analysis rules in the tests to keep them more in line with
Java.
   5. Fixes some bugs that were located in the process (such as parameters that weren't being
cascaded, and properties that weren't returning their backing field's value).
   6. Addresses some performance issues (such as removing fields and parameters that were
not in use and adding several aggressive inlining attributes).
   7. Removes some dead code and commented code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message