lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] Xebast commented on issue #394: Lucene.Net NuGet (4.8.0-beta00013) does not compile under Visual 2017 - Lucene.Net.CodeAnalysis.Lucene1000_TokenStreamOrItsIncrementTokenMethodMustBeSealedCSAnalyzer
Date Wed, 25 Nov 2020 16:30:23 GMT

Xebast commented on issue #394:
URL: https://github.com/apache/lucenenet/issues/394#issuecomment-733813602


   Hi Shad, 
   
   Thank you for your prompt answer and help! Yes, I think same about StyleCop / CodeAnalysis.
   
   I quickly tested `<PrivateAssets>all </PrivateAssets>` (Disabling Analyzers)
and result was good! In sample above, it fixes this issue.
   But that was I thought... until I use whole solution, integrating android version.
   
   So I have a new challenger : XAMARIN.
   
   In fact, `<PrivateAssets>all </PrivateAssets>` does not work in Xamarin + NetStandard;
here is a link to an OPEN issue : PrivateAssets="All" doesn't work in .netstandard csproj
for Android Xamarin : [https://github.com/NuGet/Home/issues/5128]
   
   ![XamarinBuildError](https://user-images.githubusercontent.com/33876387/100254102-2fba0800-2f42-11eb-993c-4bba0a66a0a0.jpg)
   
   So of course, I tried <PrivateAssets>compile;runtime;contentFiles;build;buildMultitargeting;buildTransitive;analyzers;native
</PrivateAssets> (simulation of all), but same result : does not compile, same error.
   
   I am now dealing with combination of IncludeAssets / Private assets, but never match all
environmement (Visual2017 / PC solution and Visual 2017 / Android Solution.) I try to combine
`compile; runtime; contentFiles; build; buildMultitargeting; buildTransitive; analyzers; native`.
Maybe there is a perfect match.
   
   We will normally move to VS2019 soon, so until, I will deactivate WarningAsError condition
in assembly clients. It is temporary. With Visual2019, FxCop nugget works fine with .NetStandard
2.0.
   
   To be honest, I did not try first recommendation about TargetVersion / TargetFramework.

   I will try it tomorrow and send you result ASAP, it could be interresting.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message