lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] Semirk0 commented on pull request #385: Adding overloads to Document for GetValues and Get
Date Wed, 18 Nov 2020 14:17:17 GMT

Semirk0 commented on pull request #385:
URL: https://github.com/apache/lucenenet/pull/385#issuecomment-729707063


   Can you explain what you mean by 
   
   > 3. Change logic of formattable `Field.ToString()` methods to test for `if (field is
IFormattable formattable)`
   
   Do you mean to change logic in class `Field` or `Document`?
   
   Also, I don't really understand 5. either. Especially 
   
   > Therefore, the Document class will still only have 2 public overloads ToString() and
ToString(IFormatProvider) that will cascade their call to an explictly implmented ToString(string,
IFormatProvider) method.
   
   Can you elaborate?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message