lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on pull request #371: Add new interface to NumericDocValues to close #370
Date Tue, 10 Nov 2020 21:49:01 GMT

NightOwl888 commented on pull request #371:
URL: https://github.com/apache/lucenenet/pull/371#issuecomment-724987108


   @theolivenbaum 
   
   I just submitted PR #389 and noticed while I was writing it up that you replied here. I
am working on getting a release vote started in the next few days, so I put together a PR
that reverts the commit https://github.com/apache/lucenenet/commit/34758c1315391794825f33a3f48b5a3dd6083745.
Rolling back the change for the release is the safest route, because it has already been thoroughly
tested.
   
   > measuring locally running our code directly referencing the Lucene projects instead
of the nuget package gave us a significant reduction in allocations.
   
   Good to hear. That boxing issue was the main culprit - it reduced RAM consumption by around
15%. But changing to use generic parameters on `Debugging.Assert` also helped a lot. On the
testing side things slowed down by about 15% when running tests locally, but on Azure DevOps
the tests are averaging about 10% faster.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message