lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] eladmarg commented on pull request #373: Remove delegate based debugging assert
Date Mon, 26 Oct 2020 09:03:11 GMT

eladmarg commented on pull request #373:
URL: https://github.com/apache/lucenenet/pull/373#issuecomment-716411038


   another option is to write custom Fody weaver but I'm not sure we should invest the efforts
on this area to gain performance.
   we have still many other areas that have bigger impact and we should focus there.
   
   for instance, there are many places we can save allocations, better re-use of allocated
objects using pools and managers.
   there are also some places we can utilize span to avoid more allocations.
   and of course, we can aggressive inline static some methods.
   
   I would even say that in the cases the code isn't in use for testing/validation and only
output, we can simply wrap it with conditional #IF TEST. (to remove it completely)
   
   I'm not sure its that necessary in all the places its used.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message