lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <>
Subject [GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator
Date Fri, 18 Aug 2017 09:58:15 GMT
Github user NightOwl888 commented on the issue:
    > If your fixing documentation comments and adding virtual modifiers, then I don't
think I have anything else to add to the code, then it's all documentation from here on.
    Well, there are...
    - Rethink HttpClientBase and HttpReplicator
    - Rethink ReplicatorService, abstractions and AspNetCore implementation.
    But I think those should probably wait until we have integrations with MVC, WebApi, and
web forms so we can ensure the pieces all fit together right. I still think you did an excellent
job of finding the lowest common denominator between any type of HTTP listener, and I doubt
we will need to refactor the request/response part of this, but there may still be some work
to do with these two classes.
    > > As for upgrading to AspNetCore 2.0, it would probably be better to multi-target
(1.0 and 2.0), since we will be adding support to run .NET Core 2.0 to the project soon (running
tests on .NET Framework 4.5.1, .NET Core 1.0, and .NET Core 2.0).
    > It was only for the Sample. I won't dive that deep for a sample TBH... It's just
meant to demonstrate how one could integrate it, nothing more... (Code wise)... And then use
that as input to the missing documentation (similar to the blog post)...
    Ahh, okay. 
    > That would provide some "example" documentation here, but it would actually be a
bit easier to share the demo project ones this PR is in and the release is out as I don't
have to pull that in in a dirty way.
    Not sure exactly what you mean by this. But, you might consider doing a [local build](
`build -pv:4.8.0-beta00005`, and then you can reference the NuGet package locally so you can
work with it as if it were a release.
    Or, if you mean you need to link to something in the repo, let me know and I will see
about finalizing the locations of everything and merging to master to facilitate your documentation

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message