lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeme <...@git.apache.org>
Subject [GitHub] lucenenet issue #209: RFC: LUCENENET-565: Porting of Lucene.Net.Replicator
Date Fri, 18 Aug 2017 09:05:58 GMT
Github user jeme commented on the issue:

    https://github.com/apache/lucenenet/pull/209
  
    Seems you misunderstood me a little bit :)...
    
    If your fixing documentation comments and adding virtual modifiers, then I don't think
I have anything else to add to the code, then it's all documentation from here on. 
    
    > As for upgrading to AspNetCore 2.0, it would probably be better to multi-target (1.0
and 2.0), since we will be adding support to run .NET Core 2.0 to the project soon (running
tests on .NET Framework 4.5.1, .NET Core 1.0, and .NET Core 2.0).
    
    It was only for the Sample. I won't dive that deep for a sample TBH... It's just meant
to demonstrate how one could integrate it, nothing more... (Code wise)... And then use that
as input to the missing documentation (similar to the blog post)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message