lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vvdb <...@git.apache.org>
Subject [GitHub] lucenenet issue #210: Corrected bug in Lifetime reference count
Date Wed, 02 Aug 2017 06:14:39 GMT
Github user vvdb commented on the issue:

    https://github.com/apache/lucenenet/pull/210
  
    Good morning Shad,
    
    I followed your detailed instruction to the letter and was so happy it worked. And “vincents-amazing-patch”
sounded creative enough <g>.
    I closed the pull request, and got this as a message:
    
    Closed with unmerged commits
    This pull request is closed, but the vvdb:vincents-amazing-patch branch has unmerged commits.
    
    … with a button  “Delete branch”. I did not click on that button. But can I? If
so, next time I’ll have a more creative name, such as vincents-attempt-at-a-pull-requests-waiting-for-Shad-s-approval.
Or something like that…
    
    Vincent
    
    From: Shad Storhaug [mailto:notifications@github.com]
    Sent: Wednesday, August 02, 2017 8:07 AM
    To: apache/lucenenet <lucenenet@noreply.github.com>
    Cc: Van Den Berghe, Vincent <Vincent.VanDenBerghe@bvdinfo.com>; Author <author@noreply.github.com>
    Subject: Re: [apache/lucenenet] Corrected bug in Lifetime reference count (#210)
    
    
    Thanks.
    
    I would have thought you would be more creative with the branch name, though.
    
    I pushed this to master, but somehow GitHub didn't get the message and left it open. For
whatever reason, I don't have the ability to close pull requests on GitHub from the UI, the
only way I can do it is by pushing another commit with a special #closes 210 commit message.
So, if you don't mind (and you can see a close button here), please close this pull request,
it is accepted.
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub<https://github.com/apache/lucenenet/pull/210#issuecomment-319576869>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/ARBXptBSLCcJVQHf5CnF-D45zdhHCuCHks5sUBIQgaJpZM4Ophnh>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message