lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <>
Subject [GitHub] lucenenet pull request: fixes for handling surrogate chars properl...
Date Wed, 31 Dec 2014 03:08:57 GMT
GitHub user laimis opened a pull request:

    fixes for handling surrogate chars properly

    TestUTF32ToUTF8.TestRandomRanges were failing because of the issue with how the surrogate
pairs were handled in Character class. Changed the implementation to call UnicodeUtils to
provide correct ToChars implementation. Now the test passes.
    Added method to UnicodeUtil to provide public API for converting code points to strings
and chars so that we don't have to do repeating conversion (char[] -> string -> char[]).

You can merge this pull request into a Git repository by running:

    $ git pull unicode_issues

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
commit 645b21d198523f984c71da307beab445285dd879
Author: Laimonas Simutis <>
Date:   2014-12-31T03:03:10Z

    fixes for handling surrogate chars properly


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message