lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prescott Nasser (JIRA)" <>
Subject [jira] [Commented] (LUCENENET-541) Performance issue with IOException in FastCharStream.
Date Fri, 30 May 2014 02:42:02 GMT


Prescott Nasser commented on LUCENENET-541:

Chris - 

I was reviewing this pull request and I have a question. You've removed all the Try/Catch
blocks but it doesn't look like any of the logic was changed. IE if the IOException is thrown
in FastCharStream.Refill, it'll bubble up the stack instead of being handled.

I think I'm missing something - either how you handled this differently or why that's not
important, in either case could you add some detail around the changes you made and how you
handle that.

> Performance issue with IOException in FastCharStream.
> -----------------------------------------------------
>                 Key: LUCENENET-541
>                 URL:
>             Project: Lucene.Net
>          Issue Type: Improvement
>          Components: Lucene.Net Core
>    Affects Versions: Lucene.Net 3.0.3, Lucene.Net 3.6, Lucene.Net 4.0
>            Reporter: Christopher Haws
>            Priority: Minor
>              Labels: performance
>   Original Estimate: 0h
>  Remaining Estimate: 0h
> The Refill() method of the FastCharStream class contains logic based on an IOException
being thrown. This logic degrades the performance of every query by about 10x from my testing.

This message was sent by Atlassian JIRA

View raw message