lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Digy (JIRA)" <>
Subject [jira] Commented: (LUCENENET-249) Many bugs fix patch
Date Sun, 15 Nov 2009 12:24:39 GMT


Digy commented on LUCENENET-249:

Hi Andrei,

Thanks for your work but;

-Some changes in your patch have already been committed to trunk, some others have been solved
in a different way.

-There are places where the whole method is deleted and replaced with a new one. This makes
harder to understand the changes.

-It is hard to use your patch unless we replace the trunk with your code.

Can you post smaller patches addressing a specific issue?


> Many bugs fix patch
> -------------------
>                 Key: LUCENENET-249
>                 URL:
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Iliev Andrei
>         Attachments: comprehensive.patch,
> All  Nunit test are passed (actually, some tests fail if run the whole tests but does
not fail if runned individulally. probably it is related with Nunit itself),
> except for:
> 1)  Lucene.Net.Index.TestDeletionPolicy.TestKeepAllDeletionPolicy
> commits.Count=15 but was expected 14
> 2) Lucene.Net.QueryParsers.TestQueryParser.TestCJK:
> Shoud be yeasly fixed for Japanese people.
> 3)3 tests in  Lucene.Net.Search.Function.TestCustomScoreQuery
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreFloat:
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreInt:
> -Lucene.Net.Search.Function.TestCustomScoreQuery.TestCustomScoreShort:
> Slight difference with the expected scores.
> Some notes:
> 1) Added support  for java NIO  (I ported java ByteBuffer/CharBuffer) -> new directory
> 2) Added new classes in SupportClass.cs
> I think it is  time to put all support classes in files in separate directory (ex. JavaSupport).
 What do you think about it?
> 3) I found that some public methods in DateTools that accept long time argument,  does
not use it as milliseconds since January 1, 1970, 00:00:00 GMT (as it is stated in the documentation).
> I think it  is not good (it diverges form java lucene). So I fixed it. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message