lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Garski <mgar...@myspace-inc.com>
Subject RE: [jira] Resolved: (LUCENENET-218) Lucene.Net.Util.TestAttributeSource.TestCloneAttributes
Date Fri, 13 Nov 2009 22:32:48 GMT
Hmmm... as that class is a helper that abstracts the differences b/w the Java collection and
the .NET implementation, I feel the opposite.  At a minimum it might be worth updating the
comment for the class to reflect its purpose and where it is used.

Michael

-----Original Message-----
From: George Aroush (JIRA) [mailto:jira@apache.org] 
Sent: Friday, November 13, 2009 1:31 PM
To: lucene-net-dev@incubator.apache.org
Subject: [jira] Resolved: (LUCENENET-218) Lucene.Net.Util.TestAttributeSource.TestCloneAttributes


     [ https://issues.apache.org/jira/browse/LUCENENET-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

George Aroush resolved LUCENENET-218.
-------------------------------------

    Resolution: Fixed

Committed.  Thanks Mike!

One small change I made is moved the class AttributeImplItem to SupportClass.  The idea is,
to keep the classes and methods 1-to-1 with Java Lucene.

> Lucene.Net.Util.TestAttributeSource.TestCloneAttributes
> -------------------------------------------------------
>
>                 Key: LUCENENET-218
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-218
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: LUCENENET-218 V3.patch, LUCENENET-218.patch, TestAttributeSource.patch
>
>
> The test is failing - I'm working on it :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message