lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Garski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk
Date Fri, 13 Nov 2009 03:33:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777357#action_12777357
] 

Michael Garski commented on LUCENENET-216:
------------------------------------------

Nice one Robert - love the addition of the Mono-specific flush call :)

One thing - would putting the static properties for the platform somewhere else be more appropriate?
 I'm sure this won't be the last time a platform switch will be needed.  Java Lucene uses
the Util.Constants class for this, and I feel we should do the same.

> FSDirectory.Sync Fix to Ensure Flush to Disk
> --------------------------------------------
>
>                 Key: LUCENENET-216
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-216
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory-Sync-PlatformIndep.patch, FSDirectory.Sync.patch
>
>
> DIGY and Doug discussed this issue during the 2.9 port, and this is a patch to give 2.9
the expected behavior of actually ensuring the OS flushes it's buffers to disk.  DIGY suggested
using the kernel32 method FlushFileBuffers, and after investigation he was correct!  FileStream.Flush
doesn't do that - the OS could still be caching it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message