lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Iliev (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-287) TestIndexWriterReader.TestUpdateDocument
Date Tue, 24 Nov 2009 13:57:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781934#action_12781934
] 

Andrei Iliev commented on LUCENENET-287:
----------------------------------------

Latest patch (SegmentInfos.patch) resolve at least 2 test cases:
TestIndexWriterReader.TestUpdateDocument 
TestIndexWriterReader.TestAddIndexes 
List of fixes:
1) EquatableList's Clone method should be virtual as it has to be overriden in SegmentInfos
(patch for SupportClass)
2)   there is  a code in IndexWriter:
((System.Collections.IList) ((System.Collections.ArrayList) segmentInfos).GetRange(start,
start + merge.segments.Count - start)).Clear();
in java it was 
segmentInfos.subList(start, start + merge.segments.size()).clear();

In java subList returns view ob the List, but in .Net it is a shallow copy of the list. This
code has been change to:
segmentInfos.RemoveRange(start, start + merge.segments.Count - start); 



> TestIndexWriterReader.TestUpdateDocument  
> ------------------------------------------
>
>                 Key: LUCENENET-287
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-287
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Andrei Iliev
>         Attachments: SegmentInfos.patch, SegmentInfos2.patch
>
>
> SegmentInfos  is derived from ArrayList. So Equals and GetHashCode should behave as java
ArrayList (see LUCENENET-284).
> After that patch TestIndexWriterReader.TestUpdateDocument is passed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message