lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-211) SupportClass.ThreadClass bug
Date Tue, 10 Nov 2009 04:01:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775268#action_12775268
] 

George Aroush commented on LUCENENET-211:
-----------------------------------------

Thanks for the patch DIGY.

A comment, and an enhancement request.

1) You are right, TestSupportClass.cs" is no longer in the project workspace, please re-add
it (this is me missing it).

2) The fact that we have now new tests that are specific to Lucene.Net means the test count
will no longer match that of Java Lucene.  This an important number to have as I use it to
compare if we ported all tests over (and that "[Test]" were not missed). 

A suggestion that I have to address #2 is to do the following. Lets add a new dummy test in
TestSupportClass.cs which all that it does is report the total number of tests this file contains
with a message saying that this sub-tests are Lucene.Net specific only.

If you agree, or if you have a better suggestion (to address #2), go ahead and commit.


> SupportClass.ThreadClass bug
> ----------------------------
>
>                 Key: LUCENENET-211
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-211
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>         Attachments: ThreadClass.patch
>
>
> While I was testing Index/TestAddIndexesNoOptimize/TestMergeAfterCopy, I found a bug
in ThreadClass which makes the indexing thread deadlocked.
> I tested the new version of  ThreadClass with earlier versions of Lucene.Net, everything
worked fine.
> I will attach a patch & test case for ThreadClass.
> BTW,  It is forgetten to add the "TestSupportClass.cs" to project file in 2.9.0.
> PS: Index/TestAddIndexesNoOptimize/TestMergeAfterCopy passes  now :-)
> DIGY

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message