lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk
Date Fri, 13 Nov 2009 20:38:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777643#action_12777643
] 

George Aroush commented on LUCENENET-216:
-----------------------------------------

Nice work Mike and Robert.  I'm ready to take this patch, but a question before I do so. 
Is there any reason why the new methods added to FSDirectory.cs, which are: IsUnix, IsWindows,
and Sync can't be moved to SupportClass?  The reason is to keep the code in par with java
Lucene as much as possible.  I can do it when I'm apply the patch.

> FSDirectory.Sync Fix to Ensure Flush to Disk
> --------------------------------------------
>
>                 Key: LUCENENET-216
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-216
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Michael Garski
>         Attachments: FSDirectory-Sync-PlatformIndep.patch, FSDirectory.Sync.patch
>
>
> DIGY and Doug discussed this issue during the 2.9 port, and this is a patch to give 2.9
the expected behavior of actually ensuring the OS flushes it's buffers to disk.  DIGY suggested
using the kernel32 method FlushFileBuffers, and after investigation he was correct!  FileStream.Flush
doesn't do that - the OS could still be caching it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message