kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chia7...@apache.org
Subject [kafka] branch trunk updated: MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexistent brokers (#10908)
Date Sat, 19 Jun 2021 15:56:05 GMT
This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 01c2345  MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexistent
brokers (#10908)
01c2345 is described below

commit 01c234565825f318b283370b55a8366816f6838f
Author: Chia-Ping Tsai <chia7712@gmail.com>
AuthorDate: Sat Jun 19 23:54:02 2021 +0800

    MINOR: fix round_trip_fault_test.py - don't assign replicas to nonexistent brokers (#10908)
    
    The broker id starts with 1 (https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/kafka/kafka.py#L207)
so round_trip_fault_test.py fails because it assigns replica to nonexistent broker.
    
    The interesting story is the failure happens only on KRaft only. KRaft mode checks the
existent ids (https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java#L950).
By contrast, ZK mode has no such check and the min.insync.replicas is set to 1 so this test
works with ZK mode even though there is one replica is always off-line.
    
    Reviewers: Ismael Juma <ismael@juma.me.uk>
---
 tests/kafkatest/tests/core/round_trip_fault_test.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kafkatest/tests/core/round_trip_fault_test.py b/tests/kafkatest/tests/core/round_trip_fault_test.py
index b674e96..72f4c66 100644
--- a/tests/kafkatest/tests/core/round_trip_fault_test.py
+++ b/tests/kafkatest/tests/core/round_trip_fault_test.py
@@ -46,7 +46,8 @@ class RoundTripFaultTest(Test):
                                       client_services=trogdor_client_services)
         topic_name = "round_trip_topic%d" % RoundTripFaultTest.topic_name_index
         RoundTripFaultTest.topic_name_index = RoundTripFaultTest.topic_name_index + 1
-        active_topics={topic_name : {"partitionAssignments":{"0": [0,1,2]}}}
+        # note that the broker.id values will be 1..num_nodes
+        active_topics={topic_name : {"partitionAssignments":{"0": [1,2,3]}}}
         self.round_trip_spec = RoundTripWorkloadSpec(0, TaskSpec.MAX_DURATION_MS,
                                      self.workload_service.client_node,
                                      self.workload_service.bootstrap_servers,

Mime
View raw message