kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkaranta...@apache.org
Subject [kafka] branch 2.6 updated: MINOR: Annotate test BlockingConnectorTest as integration test (#9379)
Date Tue, 06 Oct 2020 14:58:16 GMT
This is an automated email from the ASF dual-hosted git repository.

kkarantasis pushed a commit to branch 2.6
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.6 by this push:
     new 701bfe6  MINOR: Annotate test BlockingConnectorTest as integration test (#9379)
701bfe6 is described below

commit 701bfe67895a87f1dc7e17357bfd941fdedb0ea4
Author: Konstantine Karantasis <konstantine@confluent.io>
AuthorDate: Tue Oct 6 07:40:15 2020 -0700

    MINOR: Annotate test BlockingConnectorTest as integration test (#9379)
    
    `BlockingConnectorTest` was incorrectly running as a unit test.
    Categorize this test correctly as integration test by adding the appropriate annotation
    
    Reviewer: Randall Hauch <rhauch@gmail.com>
---
 .../apache/kafka/connect/integration/BlockingConnectorTest.java    | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
index 731a1f7..9a8e1fa 100644
--- a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
+++ b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
@@ -28,9 +28,11 @@ import org.apache.kafka.connect.source.SourceConnector;
 import org.apache.kafka.connect.source.SourceRecord;
 import org.apache.kafka.connect.source.SourceTask;
 import org.apache.kafka.connect.util.clusters.EmbeddedConnectCluster;
+import org.apache.kafka.test.IntegrationTest;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.experimental.categories.Category;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -47,6 +49,11 @@ import static org.apache.kafka.connect.runtime.ConnectorConfig.TASKS_MAX_CONFIG;
 import static org.apache.kafka.test.TestUtils.waitForCondition;
 import static org.junit.Assert.assertThrows;
 
+/**
+ * Tests situations during which certain connector operations, such as start, validation,
+ * configuration and others, take longer than expected.
+ */
+@Category(IntegrationTest.class)
 public class BlockingConnectorTest {
 
     private static final Logger log = LoggerFactory.getLogger(BlockingConnectorTest.class);


Mime
View raw message