kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mimai...@apache.org
Subject [kafka] branch trunk updated: KAFKA-10098: Remove unnecessary escaping in regular expression. (#8798)
Date Wed, 02 Sep 2020 15:32:59 GMT
This is an automated email from the ASF dual-hosted git repository.

mimaison pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 6e8a01e  KAFKA-10098: Remove unnecessary escaping in regular expression. (#8798)
6e8a01e is described below

commit 6e8a01e18cd07e95a5a9d4c1b35e279bfe9955fe
Author: Can Cecen <ccecen@lyft.com>
AuthorDate: Wed Sep 2 08:30:00 2020 -0700

    KAFKA-10098: Remove unnecessary escaping in regular expression. (#8798)
    
    '<' or '>' do not need to be escaped.
    
    Reviewers: Mickael Maison <mickael.maison@gmail.com>, Andrew Choi <andrew.choi@uwaterloo.ca>,
Jakob Homan
---
 .../kafka/common/security/authenticator/SaslAuthenticatorTest.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorTest.java
b/clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorTest.java
index b9c74c8..e1d1ef1 100644
--- a/clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorTest.java
@@ -1672,7 +1672,7 @@ public class SaslAuthenticatorTest {
                     "but instead we got our generated message echoed back, implying re-auth
succeeded when it " +
                     "should not have: " + e,
                     e.getMessage().matches(
-                            ".*\\<\\[" + expectedResponseTextRegex + "]>.*\\<\\["
+ receivedResponseTextRegex + ".*?]>"));
+                            ".*<\\[" + expectedResponseTextRegex + "]>.*<\\[" +
receivedResponseTextRegex + ".*?]>"));
             server.verifyReauthenticationMetrics(1, 0); // unchanged
         } finally { 
             selector.close();


Mime
View raw message