kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject [kafka] branch 2.5 updated: MINOR: Revert Jetty to 9.4.25 (#8183)
Date Thu, 27 Feb 2020 21:08:15 GMT
This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch 2.5
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.5 by this push:
     new d764599  MINOR: Revert Jetty to 9.4.25 (#8183)
d764599 is described below

commit d764599a7391fa4dd71050d167e3f88986ab4895
Author: Ismael Juma <ismael@juma.me.uk>
AuthorDate: Thu Feb 27 13:06:43 2020 -0800

    MINOR: Revert Jetty to 9.4.25 (#8183)
    
    9.4.25 renamed closeOutput to completeOutput
    (https://github.com/eclipse/jetty.project/commit/c5acf965067478784b54e2d241ec58fdb0b2c9fe),
    which is a method used by recent Jersey versions including the
    latest (2.30.1). An example of the error:
    
    > java.lang.NoSuchMethodError: org.eclipse.jetty.server.Response.closeOutput()V
    > 	at org.glassfish.jersey.jetty.JettyHttpContainer$ResponseWriter.commit(JettyHttpContainer.java:326)
    
    The request still completes and hence why no test fails. We should think about how
    to improve the testing for this kind of problem, but I want to get the fix in before
    2.5 RC0.
    
    Credit to @rigelbm for finding this.
    
    Reviewers: Ewen Cheslack-Postava <me@ewencp.org>, Andrew Choi <a24choi@edu.uwaterloo.ca>
---
 gradle/dependencies.gradle | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index d6098e4..5e766b7 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -70,7 +70,10 @@ versions += [
   easymock: "4.1",
   jackson: "2.10.2",
   jacoco: "0.8.3",
-  jetty: "9.4.26.v20200117",
+  // 9.4.25 renamed closeOutput to completeOutput (https://github.com/eclipse/jetty.project/commit/c5acf965067478784b54e2d241ec58fdb0b2c9fe)
+  // which is a method used by recent Jersey versions when this comment was written (2.30.1
was the latest). Please
+  // verify that this is fixed in some way before bumping the Jetty version.
+  jetty: "9.4.24.v20191120",
   jersey: "2.28",
   jmh: "1.23",
   hamcrest: "2.2",


Mime
View raw message