kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject [kafka] branch trunk updated: KAFKA-8344; Fix vagrant-up.sh to work with AWS properly
Date Fri, 10 May 2019 05:48:50 GMT
This is an automated email from the ASF dual-hosted git repository.

gwenshap pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new c638235  KAFKA-8344; Fix vagrant-up.sh to work with AWS properly
c638235 is described below

commit c638235dbc0019b67fd520378d7efdcfd8dec0c0
Author: Kengo Seki <sekikn@apache.org>
AuthorDate: Thu May 9 22:48:23 2019 -0700

    KAFKA-8344; Fix vagrant-up.sh to work with AWS properly
    
    For now, `vagrant/vagrant-up.sh --aws` fails because
    the `vagrant hostmanager` command in that script lacks
    the `--aws` option. This PR adds it.
    
    I ran `vagrant/vagrant-up.sh --aws` with and without
    `--no-parallel` option and confirmed both worked
    as expected.
    
    Author: Kengo Seki <sekikn@apache.org>
    
    Reviewers: Gwen Shapira
    
    Closes #6703 from sekikn/KAFKA-8344
---
 vagrant/vagrant-up.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vagrant/vagrant-up.sh b/vagrant/vagrant-up.sh
index 6a4ef95..9210a53 100755
--- a/vagrant/vagrant-up.sh
+++ b/vagrant/vagrant-up.sh
@@ -220,7 +220,7 @@ function bring_up_aws {
             # We still have to bring up zookeeper/broker nodes serially
             echo "Bringing up zookeeper/broker machines serially"
             vagrant up --provider=aws --no-parallel --no-provision $zk_broker_machines $debug
-            vagrant hostmanager
+            vagrant hostmanager --provider=aws
             vagrant provision
         fi
 
@@ -231,11 +231,11 @@ function bring_up_aws {
             local vagrant_rsync_temp_dir=$(mktemp -d);
             TMPDIR=$vagrant_rsync_temp_dir vagrant_batch_command "vagrant up $debug --provider=aws"
"$worker_machines" "$max_parallel"
             rm -rf $vagrant_rsync_temp_dir
-            vagrant hostmanager
+            vagrant hostmanager --provider=aws
         fi
     else
         vagrant up --provider=aws --no-parallel --no-provision $debug
-        vagrant hostmanager
+        vagrant hostmanager --provider=aws
         vagrant provision
     fi
 


Mime
View raw message