kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject [kafka] branch trunk updated: MINOR: correctly parse version OffsetCommitResponse version < 3
Date Wed, 08 May 2019 03:26:01 GMT
This is an automated email from the ASF dual-hosted git repository.

gwenshap pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8308829  MINOR: correctly parse version OffsetCommitResponse version < 3
8308829 is described below

commit 8308829e46fcc4903b9faa3d2dcdf10f56f262fe
Author: Lucas Bradstreet <lucas@confluent.io>
AuthorDate: Tue May 7 20:25:37 2019 -0700

    MINOR: correctly parse version OffsetCommitResponse version < 3
    
    KAFKA-7903: automatically generate OffsetCommitRequest (#6583) introduced a change that
cause consumer breakage when OffsetCommitResponse versions < 3 are parsed, as they do not
include a throttle_time_ms field. This PR fixes the parsing by supplying the correct version
to the OffsetCommitResponse constructor in AbstractResponse.parseResponse.
    
    I have tested this change against many of the compatibility system tests, and it has fixed
all the failures that I have tested thus far.
    
    Author: Lucas Bradstreet <lucas@confluent.io>
    
    Reviewers: Gwen Shapira, Boyang Chen
    
    Closes #6698 from lbradstreet/offset-commit-response-throttle-field
---
 .../main/java/org/apache/kafka/common/requests/AbstractResponse.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
b/clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
index 9c747ec..7ba9b7a 100644
--- a/clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
+++ b/clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
@@ -79,7 +79,7 @@ public abstract class AbstractResponse extends AbstractRequestResponse {
             case METADATA:
                 return new MetadataResponse(struct, version);
             case OFFSET_COMMIT:
-                return new OffsetCommitResponse(struct);
+                return new OffsetCommitResponse(struct, version);
             case OFFSET_FETCH:
                 return new OffsetFetchResponse(struct);
             case FIND_COORDINATOR:


Mime
View raw message