kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guozh...@apache.org
Subject [kafka] branch trunk updated: KAFKA-6620: Fix documentation about 'exactly_once'
Date Fri, 28 Sep 2018 21:42:02 GMT
This is an automated email from the ASF dual-hosted git repository.

guozhang pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new e7b6d65  KAFKA-6620: Fix documentation about 'exactly_once'
e7b6d65 is described below

commit e7b6d65713857e55453e4558957fbd3c7a68ea04
Author: Lee Dongjin <dongjin@apache.org>
AuthorDate: Sat Sep 29 06:41:50 2018 +0900

    KAFKA-6620: Fix documentation about 'exactly_once'
    
    Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
---
 docs/streams/developer-guide/config-streams.html                  | 2 +-
 streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/streams/developer-guide/config-streams.html b/docs/streams/developer-guide/config-streams.html
index 75f1045..a226517 100644
--- a/docs/streams/developer-guide/config-streams.html
+++ b/docs/streams/developer-guide/config-streams.html
@@ -452,7 +452,7 @@
                  and producers are configured with <code class="docutils literal"><span
class="pre">retries=Integer.MAX_VALUE</span></code>, <code class="docutils
literal"><span class="pre">enable.idempotence=true</span></code>,
                  and <code class="docutils literal"><span class="pre">max.in.flight.requests.per.connection=1</span></code>
per default.
                  Note that by default exactly-once processing requires a cluster of at least
three brokers what is the recommended setting for production.
-                 For development you can change this, by adjusting broker setting <code
class="docutils literal"><span class="pre">transaction.state.log.replication.factor</span></code>
to the number of broker you want to use.
+                 For development you can change this, by adjusting broker setting <code
class="docutils literal"><span class="pre">transaction.state.log.replication.factor</span></code>
and <code class="docutils literal"><span class="pre">transaction.state.log.min.isr</span></code>
to the number of broker you want to use.
                  For more details see <a href="../core-concepts#streams_processing_guarantee">Processing
Guarantees</a>.
             </div></blockquote>
         </div>
diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
index 20f2f69..b112a54 100644
--- a/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
+++ b/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
@@ -396,7 +396,8 @@ public class StreamsConfig extends AbstractConfig {
     @SuppressWarnings("WeakerAccess")
     public static final String PROCESSING_GUARANTEE_CONFIG = "processing.guarantee";
     private static final String PROCESSING_GUARANTEE_DOC = "The processing guarantee that
should be used. Possible values are <code>" + AT_LEAST_ONCE + "</code> (default)
and <code>" + EXACTLY_ONCE + "</code>. " +
-        "Note that exactly-once processing requires a cluster of at least three brokers by
default what is the recommended setting for production; for development you can change this,
by adjusting broker setting <code>transaction.state.log.replication.factor</code>.";
+        "Note that exactly-once processing requires a cluster of at least three brokers by
default what is the recommended setting for production; for development you can change this,
by adjusting broker setting " +
+        "<code>transaction.state.log.replication.factor</code> and <code>transaction.state.log.min.isr</code>.";
 
     /** {@code receive.buffer.bytes} */
     @SuppressWarnings("WeakerAccess")


Mime
View raw message