kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ij...@apache.org
Subject [kafka] branch trunk updated: MINOR: Split at first occurrence of '=' in kafka.py props parsing (#5549)
Date Wed, 22 Aug 2018 06:43:05 GMT
This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 3511e90  MINOR: Split at first occurrence of '=' in kafka.py props parsing (#5549)
3511e90 is described below

commit 3511e904effbfb74fa54c26467477863b7f730c0
Author: Robert Yokota <rayokota@gmail.com>
AuthorDate: Tue Aug 21 23:42:56 2018 -0700

    MINOR: Split at first occurrence of '=' in kafka.py props parsing (#5549)
    
    This is a fix to #5226 to account for config properties that have an
    equal char in the value.   Otherwise if there is one
    equal char in the value the following error occurs:
    
    dictionary update sequence element #XX has length 3; 2 is required
    
    Reviewers: Colin Patrick McCabe <colin@cmccabe.xyz>, Ismael Juma <ismael@juma.me.uk>
---
 tests/kafkatest/services/kafka/kafka.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kafkatest/services/kafka/kafka.py b/tests/kafkatest/services/kafka/kafka.py
index b0a9faa..c3cc9f7 100644
--- a/tests/kafkatest/services/kafka/kafka.py
+++ b/tests/kafkatest/services/kafka/kafka.py
@@ -217,7 +217,7 @@ class KafkaService(KafkaPathResolverMixin, JmxMixin, Service):
         config_template = self.render('kafka.properties', node=node, broker_id=self.idx(node),
                                  security_config=self.security_config, num_nodes=self.num_nodes)
 
-        configs = dict( l.rstrip().split('=') for l in config_template.split('\n')
+        configs = dict( l.rstrip().split('=', 1) for l in config_template.split('\n')
                         if not l.startswith("#") and "=" in l )
 
         #load specific test override configs


Mime
View raw message