kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject [kafka] branch trunk updated: MINOR: KIP-211 Follow-up (#5272)
Date Tue, 26 Jun 2018 14:57:35 GMT
This is an automated email from the ASF dual-hosted git repository.

jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9bc9a37  MINOR: KIP-211 Follow-up (#5272)
9bc9a37 is described below

commit 9bc9a37e50e403a356a4f10d6df12e9f808d4fba
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
AuthorDate: Tue Jun 26 07:57:28 2018 -0700

    MINOR: KIP-211 Follow-up (#5272)
    
    Updates the description of `offsets.retention.minutes` config, and fixes an upgrade note.
---
 core/src/main/scala/kafka/coordinator/group/OffsetConfig.scala | 3 ++-
 core/src/main/scala/kafka/server/KafkaConfig.scala             | 3 ++-
 docs/upgrade.html                                              | 5 ++---
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/core/src/main/scala/kafka/coordinator/group/OffsetConfig.scala b/core/src/main/scala/kafka/coordinator/group/OffsetConfig.scala
index 2b9a60f..55ec590 100644
--- a/core/src/main/scala/kafka/coordinator/group/OffsetConfig.scala
+++ b/core/src/main/scala/kafka/coordinator/group/OffsetConfig.scala
@@ -23,7 +23,8 @@ import kafka.message.{CompressionCodec, NoCompressionCodec}
  * Configuration settings for in-built offset management
  * @param maxMetadataSize The maximum allowed metadata for any offset commit.
  * @param loadBufferSize Batch size for reading from the offsets segments when loading offsets
into the cache.
- * @param offsetsRetentionMs Offsets older than this retention period will be discarded.
+ * @param offsetsRetentionMs After a consumer group loses all its consumers (i.e. becomes
empty) its offsets will be kept for this retention period before getting discarded.
+ *                           For standalone consumers (using manual assignment), offsets
will be expired after the time of last commit plus this retention period.
  * @param offsetsRetentionCheckIntervalMs Frequency at which to check for expired offsets.
  * @param offsetsTopicNumPartitions The number of partitions for the offset commit topic
(should not change after deployment).
  * @param offsetsTopicSegmentBytes The offsets topic segment bytes should be kept relatively
small to facilitate faster
diff --git a/core/src/main/scala/kafka/server/KafkaConfig.scala b/core/src/main/scala/kafka/server/KafkaConfig.scala
index 2760def..aeccc34 100755
--- a/core/src/main/scala/kafka/server/KafkaConfig.scala
+++ b/core/src/main/scala/kafka/server/KafkaConfig.scala
@@ -657,7 +657,8 @@ object KafkaConfig {
   val OffsetsTopicPartitionsDoc = "The number of partitions for the offset commit topic (should
not change after deployment)"
   val OffsetsTopicSegmentBytesDoc = "The offsets topic segment bytes should be kept relatively
small in order to facilitate faster log compaction and cache loads"
   val OffsetsTopicCompressionCodecDoc = "Compression codec for the offsets topic - compression
may be used to achieve \"atomic\" commits"
-  val OffsetsRetentionMinutesDoc = "Offsets older than this retention period will be discarded"
+  val OffsetsRetentionMinutesDoc = "After a consumer group loses all its consumers (i.e.
becomes empty) its offsets will be kept for this retention period before getting discarded.
" +
+    "For standalone consumers (using manual assignment), offsets will be expired after the
time of last commit plus this retention period."
   val OffsetsRetentionCheckIntervalMsDoc = "Frequency at which to check for stale offsets"
   val OffsetCommitTimeoutMsDoc = "Offset commit will be delayed until all replicas for the
offsets topic receive the commit " +
   "or this timeout is reached. This is similar to the producer request timeout."
diff --git a/docs/upgrade.html b/docs/upgrade.html
index 26c0d15..2c68717 100644
--- a/docs/upgrade.html
+++ b/docs/upgrade.html
@@ -28,6 +28,8 @@
         empty all its offsets will be removed after default offset retention period (or the
one set by broker) has passed (unless the group becomes
         active again). Offsets associated with standalone (simple) consumers, that do not
use Kafka group management, will be removed after default
         offset retention period (or the one set by broker) has passed since their last commit.</li>
+    <li>The default for console consumer's <code>enable.auto.commit</code>
property when no <code>group.id</code> is provided is now set to <code>false</code>.
+        This is to avoid polluting the consumer coordinator cache as the auto-generated group
is not likely to be used by other consumers.</li>
 </ol>
 
 
@@ -78,9 +80,6 @@
         until all brokers in the cluster have been updated.
         <p><b>NOTE:</b> any prefixed ACLs added to a cluster, even after
the cluster is fully upgraded, will be ignored should the cluster be downgraded again.
     </li>
-    <li>The default for console consumer's <code>enable.auto.commit</code>
property when no <code>group.id</code> is provided is now set to <code>false</code>.
-        This is to avoid polluting the consumer coordinator cache as the auto-generated group
is not likely to be used by other consumers.
-    </li>
 </ol>
 
 <h5><a id="upgrade_200_notable" href="#upgrade_200_notable">Notable changes in
2.0.0</a></h5>


Mime
View raw message