kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject kafka git commit: trivial change to clarify comments in KAFKA-4229
Date Tue, 24 Jan 2017 23:20:35 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 3f0168cd3 -> 2a5db4d6c


trivial change to clarify comments in KAFKA-4229


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2a5db4d6
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2a5db4d6
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2a5db4d6

Branch: refs/heads/trunk
Commit: 2a5db4d6c46fbc9c42cdaef1da19cdbda945a3d3
Parents: 3f0168c
Author: Jun Rao <junrao@gmail.com>
Authored: Tue Jan 24 15:17:26 2017 -0800
Committer: Jun Rao <junrao@gmail.com>
Committed: Tue Jan 24 15:17:26 2017 -0800

----------------------------------------------------------------------
 core/src/main/scala/kafka/controller/KafkaController.scala | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/2a5db4d6/core/src/main/scala/kafka/controller/KafkaController.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/controller/KafkaController.scala b/core/src/main/scala/kafka/controller/KafkaController.scala
index b0ed8d7..e38adf8 100644
--- a/core/src/main/scala/kafka/controller/KafkaController.scala
+++ b/core/src/main/scala/kafka/controller/KafkaController.scala
@@ -1169,7 +1169,9 @@ class KafkaController(val config: KafkaConfig, zkUtils: ZkUtils, val
brokerState
           controllerElector.elect
         }
       } else {
-        //maybe create by current session or the previous zk session's ephemeral node is
not deleted
+        // This can happen when there are multiple consecutive session expiration and handleNewSession()
are called multiple
+        // times. The first call may already register the controller path using the newest
ZK session. Therefore, the
+        // controller path will exist in subsequent calls to handleNewSession().
         info("ZK expired, but the current controller id %d is the same as this broker id,
skip re-elect".format(config.brokerId))
       }
     }


Mime
View raw message