kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gwens...@apache.org
Subject kafka git commit: KAFKA-3435: Remove `Unstable` annotation from new Java Consumer
Date Tue, 22 Mar 2016 18:53:31 GMT
Repository: kafka
Updated Branches:
  refs/heads/0.10.0 808f85f03 -> c0f870f85


KAFKA-3435: Remove `Unstable` annotation from new Java Consumer

Author: Grant Henke <granthenke@gmail.com>

Reviewers: Gwen Shapira

Closes #1113 from granthenke/remove-unstable

(cherry picked from commit 99cfb99aa161007f2ceae33945d11b968d932175)
Signed-off-by: Gwen Shapira <cshapi@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/c0f870f8
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/c0f870f8
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/c0f870f8

Branch: refs/heads/0.10.0
Commit: c0f870f8509253564c73ca76cd9fabb7df4ce6ad
Parents: 808f85f
Author: Grant Henke <granthenke@gmail.com>
Authored: Tue Mar 22 11:53:12 2016 -0700
Committer: Gwen Shapira <cshapi@gmail.com>
Committed: Tue Mar 22 11:53:25 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/kafka/clients/consumer/Consumer.java |  5 ++---
 .../org/apache/kafka/clients/consumer/KafkaConsumer.java | 11 +++++------
 2 files changed, 7 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/c0f870f8/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java b/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
index 0862c32..ef80606 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
@@ -3,9 +3,9 @@
  * file distributed with this work for additional information regarding copyright ownership.
The ASF licenses this file
  * to You under the Apache License, Version 2.0 (the "License"); you may not use this file
except in compliance with the
  * License. You may obtain a copy of the License at
- * 
+ *
  * http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on
  * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the
  * specific language governing permissions and limitations under the License.
@@ -29,7 +29,6 @@ import java.util.regex.Pattern;
  * @see KafkaConsumer
  * @see MockConsumer
  */
-@InterfaceStability.Unstable
 public interface Consumer<K, V> extends Closeable {
 
     /**

http://git-wip-us.apache.org/repos/asf/kafka/blob/c0f870f8/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
index c36b7f1..1031252 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
@@ -165,11 +165,11 @@ import java.util.regex.Pattern;
  * In this example the client is subscribing to the topics <i>foo</i> and <i>bar</i>
as part of a group of consumers
  * called <i>test</i> as described above.
  * <p>
- * The broker will automatically detect failed processes in the <i>test</i> group
by using a heartbeat mechanism. The 
- * consumer will automatically ping the cluster periodically, which lets the cluster know
that it is alive. Note that 
- * the consumer is single-threaded, so periodic heartbeats can only be sent when {@link #poll(long)}
is called. As long as 
- * the consumer is able to do this it is considered alive and retains the right to consume
from the partitions assigned 
- * to it. If it stops heartbeating by failing to call {@link #poll(long)} for a period of
time longer than <code>session.timeout.ms</code> 
+ * The broker will automatically detect failed processes in the <i>test</i> group
by using a heartbeat mechanism. The
+ * consumer will automatically ping the cluster periodically, which lets the cluster know
that it is alive. Note that
+ * the consumer is single-threaded, so periodic heartbeats can only be sent when {@link #poll(long)}
is called. As long as
+ * the consumer is able to do this it is considered alive and retains the right to consume
from the partitions assigned
+ * to it. If it stops heartbeating by failing to call {@link #poll(long)} for a period of
time longer than <code>session.timeout.ms</code>
  * then it will be considered dead and its partitions will be assigned to another process.
  * <p>
  * The deserializer settings specify how to turn bytes into objects. For example, by specifying
string deserializers, we
@@ -452,7 +452,6 @@ import java.util.regex.Pattern;
  * commit.
  *
  */
-@InterfaceStability.Unstable
 public class KafkaConsumer<K, V> implements Consumer<K, V> {
 
     private static final Logger log = LoggerFactory.getLogger(KafkaConsumer.class);


Mime
View raw message