kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject kafka git commit: MINOR: Reduce logging level for controller connection failures from `error` to `warn`
Date Mon, 19 Oct 2015 20:39:26 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk 241b9ab58 -> 964114a8a


MINOR: Reduce logging level for controller connection failures from `error` to `warn`

Before we switched from `BlockingChannel` to `NetworkClient`, we were
always reporting a successful connection due to the fact that
`BlockingChannel.connect` catches and swallows all exceptions. We
are now reporting failures (which is better), but `error` seems too
noisy (as can be seen in our tests).

Author: Ismael Juma <ismael@juma.me.uk>

Reviewers: Jun Rao <junrao@gmail.com>

Closes #280 from ijuma/reduce-connection-failure-logging-level


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/964114a8
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/964114a8
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/964114a8

Branch: refs/heads/trunk
Commit: 964114a8aa28024f0e34693bb78da618f36574d3
Parents: 241b9ab
Author: Ismael Juma <ismael@juma.me.uk>
Authored: Mon Oct 19 13:39:19 2015 -0700
Committer: Jun Rao <junrao@gmail.com>
Committed: Mon Oct 19 13:39:19 2015 -0700

----------------------------------------------------------------------
 .../src/main/scala/kafka/controller/ControllerChannelManager.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/964114a8/core/src/main/scala/kafka/controller/ControllerChannelManager.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/controller/ControllerChannelManager.scala b/core/src/main/scala/kafka/controller/ControllerChannelManager.scala
index 64e3355..c2076a2 100755
--- a/core/src/main/scala/kafka/controller/ControllerChannelManager.scala
+++ b/core/src/main/scala/kafka/controller/ControllerChannelManager.scala
@@ -232,7 +232,7 @@ class RequestSendThread(val controllerId: Int,
       }
     } catch {
       case e: Throwable =>
-        error("Controller %d's connection to broker %s was unsuccessful".format(controllerId,
toBroker.toString()), e)
+        warn("Controller %d's connection to broker %s was unsuccessful".format(controllerId,
toBroker.toString()), e)
         networkClient.close(brokerNode.idString)
         false
     }


Mime
View raw message