kafka-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jun...@apache.org
Subject git commit: kafka-1620; Make kafka api protocol implementation public; patched by Anton Karamanov; reviewed by Jun Rao
Date Wed, 17 Sep 2014 16:50:15 GMT
Repository: kafka
Updated Branches:
  refs/heads/trunk a1423aec7 -> c892c08df


kafka-1620; Make kafka api protocol implementation public; patched by Anton Karamanov; reviewed
by Jun Rao


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/c892c08d
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/c892c08d
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/c892c08d

Branch: refs/heads/trunk
Commit: c892c08df01c3dfc2d466bd37a6838072d390819
Parents: a1423ae
Author: Anton Karamanov <ataraxer@gmail.com>
Authored: Wed Sep 17 09:50:10 2014 -0700
Committer: Jun Rao <junrao@gmail.com>
Committed: Wed Sep 17 09:50:10 2014 -0700

----------------------------------------------------------------------
 core/src/main/scala/kafka/api/FetchRequest.scala      | 14 +++++++-------
 core/src/main/scala/kafka/api/RequestOrResponse.scala |  2 +-
 core/src/main/scala/kafka/cluster/Broker.scala        |  4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/c892c08d/core/src/main/scala/kafka/api/FetchRequest.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/api/FetchRequest.scala b/core/src/main/scala/kafka/api/FetchRequest.scala
index 51cdccf..59c0915 100644
--- a/core/src/main/scala/kafka/api/FetchRequest.scala
+++ b/core/src/main/scala/kafka/api/FetchRequest.scala
@@ -59,13 +59,13 @@ object FetchRequest {
   }
 }
 
-case class FetchRequest private[kafka] (versionId: Short = FetchRequest.CurrentVersion,
-                                        correlationId: Int = FetchRequest.DefaultCorrelationId,
-                                        clientId: String = ConsumerConfig.DefaultClientId,
-                                        replicaId: Int = Request.OrdinaryConsumerId,
-                                        maxWait: Int = FetchRequest.DefaultMaxWait,
-                                        minBytes: Int = FetchRequest.DefaultMinBytes,
-                                        requestInfo: Map[TopicAndPartition, PartitionFetchInfo])
+case class FetchRequest(versionId: Short = FetchRequest.CurrentVersion,
+                        correlationId: Int = FetchRequest.DefaultCorrelationId,
+                        clientId: String = ConsumerConfig.DefaultClientId,
+                        replicaId: Int = Request.OrdinaryConsumerId,
+                        maxWait: Int = FetchRequest.DefaultMaxWait,
+                        minBytes: Int = FetchRequest.DefaultMinBytes,
+                        requestInfo: Map[TopicAndPartition, PartitionFetchInfo])
         extends RequestOrResponse(Some(RequestKeys.FetchKey)) {
 
   /**

http://git-wip-us.apache.org/repos/asf/kafka/blob/c892c08d/core/src/main/scala/kafka/api/RequestOrResponse.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/api/RequestOrResponse.scala b/core/src/main/scala/kafka/api/RequestOrResponse.scala
index 0334343..73ec1d9 100644
--- a/core/src/main/scala/kafka/api/RequestOrResponse.scala
+++ b/core/src/main/scala/kafka/api/RequestOrResponse.scala
@@ -30,7 +30,7 @@ object Request {
 }
 
 
-private[kafka] abstract class RequestOrResponse(val requestId: Option[Short] = None) extends
Logging {
+abstract class RequestOrResponse(val requestId: Option[Short] = None) extends Logging {
 
   def sizeInBytes: Int
   

http://git-wip-us.apache.org/repos/asf/kafka/blob/c892c08d/core/src/main/scala/kafka/cluster/Broker.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/kafka/cluster/Broker.scala b/core/src/main/scala/kafka/cluster/Broker.scala
index 9407ed2..ccc3fc1 100644
--- a/core/src/main/scala/kafka/cluster/Broker.scala
+++ b/core/src/main/scala/kafka/cluster/Broker.scala
@@ -26,7 +26,7 @@ import kafka.common.{KafkaException, BrokerNotAvailableException}
 /**
  * A Kafka broker
  */
-private[kafka] object Broker {
+object Broker {
 
   def createBroker(id: Int, brokerInfoString: String): Broker = {
     if(brokerInfoString == null)
@@ -54,7 +54,7 @@ private[kafka] object Broker {
   }
 }
 
-private[kafka] case class Broker(val id: Int, val host: String, val port: Int) {
+case class Broker(val id: Int, val host: String, val port: Int) {
   
   override def toString(): String = new String("id:" + id + ",host:" + host + ",port:" +
port)
 


Mime
View raw message