juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [juneau] jamesbognar commented on a change in pull request #55: Java api fixes
Date Thu, 12 Nov 2020 17:29:40 GMT

jamesbognar commented on a change in pull request #55:
URL: https://github.com/apache/juneau/pull/55#discussion_r522285530



##########
File path: juneau-core/juneau-marshall/src/main/java/org/apache/juneau/internal/IOUtils.java
##########
@@ -578,8 +570,6 @@ public static void close(Object...o) throws IOException {
 		IOException ex = null;
 		for (Object o2 : o) {
 			try {
-				if (o2 instanceof InputStream)
-					((InputStream)o2).close();

Review comment:
       The IOUtils.close(Object...) method is also a general utility method that's supposed
to work on InputStreams.  So this code also should not be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message