juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Release Apache Juneau 8.1.3 RC2
Date Tue, 14 Jan 2020 11:43:16 GMT
My vote is +1 (see below)

[+] sha512 checksums correct
[+] git commit vs tag
[+] git vs src zip 
[+] mvn apache-rat:rat
[+] no unexpected binaries in src
[+] mvn clean install  (JDK8 OK, fails JDK11)
[+] bin vs built
[+] mvn repo vs bin
[+] mvn repo vs src
[+] examples build (tested w JDK11)
.. however, oh no, what have I done..?

tools.jar is missing from JDK11 (it's all in modules now) and in addition
the com.sun.* packages have since JDK9 been superseeded by the
jdk.javadoc.doclet.Taglet interface and friends

.. which although nicer, are not quite the same method signatures
as the old doclet interfaces.

[INFO] juneau/doc ......................................... FAILURE [  0.011 s]
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:01 min
[INFO] Finished at: 2020-01-14T11:06:51Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project juneau-doc: Could not resolve dependencies for project
org.apache.juneau:juneau-doc:bundle:8.1.3: Could not find artifact com.sun:tools:jar:1.8.0
at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1]

Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00)
Maven home: /home/stain/software/maven
Java version: 11.0.5, vendor: Private Build, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-74-generic", arch: "amd64", family: "unix"


Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_232, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-74-generic", arch: "amd64", family: "unix"

If I used JDK8 the src builds well, perhaps just add that requirement to
build instructions  - longer term I guess we don't want to require Java
8 to do a release and could rather move to the new interfaces, then the
Juneau javadoc tags would presumably no longer work with Java 8 ..

I assuming here we are OK with this point release depending on JDK8 to
build from src, I tested all the examples with JDK11 so the bins works

Thus my vote is: +1

On Mon, 13 Jan 2020 14:48:33 -0500, James Bognar <jamesbognar@apache.org> wrote:
> I am pleased to be calling this vote for the source release of Apache
> Juneau 8.1.3 RC2.
> The binaries are available at:
> https://dist.apache.org/repos/dist/dev/juneau/binaries/juneau-8.1.3-RC2/
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/juneau/source/juneau-8.1.3-RC2/
> SHA-512 checksums:
> apache-juneau-8.1.3-src.zip:
>                              1270D46F 1CD59CC8 458BF1A5 14373928 BBEA4767
>                              C2C98FFC F6EB9663 5230C4C1 DEB16285 4F76AEDF
>                              C644DD2D CBDA784D 5AE2CAFB 6731DD07 4E8E89AE
>                              A2867840
> apache-juneau-8.1.3-bin.zip:
>                              A83B8613 1AA2C981 08F41F17 8EED3881 ADFF5FC8
>                              BC620725 863AC4D2 6F8BA3E0 99BAFCC3 A0936E12
>                              08738CD7 251393C9 E3BCF675 F2540561 FC32B69D
>                              B1B79D6E
> Build the release candidate using:
> mvn clean install
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/release/juneau/KEYS
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachejuneau-1031/
> The Git commit for this release is...
> https://gitbox.apache.org/repos/asf?p=juneau.git;a=commit;h=240d5ad568efa9ed423e47cce704437ae5070f08
> Please vote on releasing this package as:
> Apache Juneau 8.1.3
> This vote will be open until 16-Jan-2020 3:00pm and passes if a
> majority of at least three +1 Apache Juneau PMC votes are cast.
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
> Anyone can participate in testing and voting, not just committers,
> please feel free to try out the release candidate and provide your
> votes.

View raw message