juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] incubator-juneau pull request #3: resolves JUNEAU-55
Date Thu, 15 Jun 2017 15:50:06 GMT
Github user johnament commented on a diff in the pull request:

    --- Diff: juneau-core/src/main/java/org/apache/juneau/remoteable/RemoteableMethodMeta.java
    @@ -74,8 +74,8 @@ private Builder(String restUrl, Method m) {
     			RemoteMethod rm = m.getAnnotation(RemoteMethod.class);
     			httpMethod = rm == null ? "POST" : rm.httpMethod();
    -			if (! isOneOf(httpMethod, "GET", "POST"))
    -				throw new RemoteableMetadataException(m, "Invalid value specified for @RemoteMethod.httpMethod()
annotation.  Valid values are [GET,POST].");
    +			if (! isOneOf(httpMethod, "DELETE", "GET", "POST", "PUT"))
    --- End diff --
    Should we perhaps use an enum?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message