juneau-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Release Apache Juneau 6.0.1-incubating RC1
Date Sun, 27 Nov 2016 15:59:30 GMT
My vote: +1 (binding)

I did find a build error you may want to look at.

The VOTE email did not specify dist.apache.org sha1 hashes or SVN
revision number, so I'll assume r17105.

which means sha1 hashes:
3d063fff5bf08f7c7cb59b3bd730e7cafa861ce7  apache-juneau-6.0.1-incubating-bin.zip

The VOTE email did not include git tag or commit.
I'll assume tag juneau-6.0.1-incubating-RC1 (commit

For the next (and incubator vote), please make sure you include hashes
and git commit, they form part of the mailing list archive and can be
used for auditing purposes. It also helps detect an accidental "second
release candidate 1" problem :)

-0 source release does not have "apache-" in archive/folder name
(also inconsistent with -bin filename)
+1 -incubator in archive names/version
+0 git tag matches source release (git contains spurious Eclipse and
OSX files like .DS_Store, .classpath, .project, .settings - they
should not be in git)
-0 mvn clean install FAILS test - locale-assumptions? (I'm en_GB)
-DskipTests works though.
+1 LICENSE, NOTICE  (but should not IBM/Salesforce be credited for
pre-2016 copyright?)
-0 RELEASE-NOTES.txt in archive has 6.0.0 details, but not 6.0.1 -
probably not critical for point release
+1 all JARs in staging can be built from source
+1 repository matches dist (same sha1 for source-release.zip and -bin.zip)
+1 binaries archive has LICENSE, NOTICE, DISCLAIMER
+1 OSGi bundles in binaries only include org.apache.juneau stuff (thus
don't need modified LICENSE/NOTICE)

If you don't want to fix the locale bug for this release candidate,
then you will need to instruct the incubator VOTE on how to override
the locale or skip the test.

Failed tests:
expected:<<string>[Mar 3, ]1901</string>> but
expected:<'[Mar 3, ]1901'> but was:<'[03-Mar-]1901'>
expected:<...escription><j:value>[Mar 3, ]1901</j:value></rdf:...>
expected:<[Mar+3,+]1901> but was:<[03-Mar-]1901>
expected:<_value=[Mar+3,+]1901> but was:<_value=[03-Mar-]1901>
expected:<<string>[Mar 3, ]1901</string>> but
Tests in error:
  DataConversionTest.testObjectSwaps:138 » InvalidDataConversion
Invalid data co...
  RdfParserTest.testParseIntoGenericPojos:36 » Parse Unparseable date:
"Jan 1, 1...

 mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
Maven home: /home/stain/software/maven
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-47-generic", arch: "amd64", family: "unix"

On 21 November 2016 at 15:23, James Bognar <jamesbognar@apache.org> wrote:
> I am pleased to be calling this vote for the source release of Apache
> Juneau 6.0.1-incubating RC1.
> This is a minor release that fixes edge-case bugs in the JSON parser and
> resolved minor release issues found in the 6.0.0 candidate.
> To discuss this release candidate, use the corresponding [DISCUSS] thread.
> The binaries are available at:
> https://dist.apache.org/repos/dist/dev/incubator/juneau/binaries/juneau-6.0.1-incubating-RC1/
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/juneau/source/juneau-6.0.1-incubating-RC1/
> Build the release candidate using:
> mvn clean install
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/release/incubator/juneau/KEYS
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachejuneau-1005/
> Please vote on releasing this package as:
> Apache Juneau 6.0.1-incubating
> The vote is open for at least 72 hours and passes if a majority of at least
> three +1 Apache Juneau PPMC votes are cast.
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.

Stian Soiland-Reyes

View raw message